On 9/23/21 7:35 PM, Biju Das wrote: [...] >>> Rename the variable "no_ptp_cfg_active" with "no_gptp" with inverted >>> checks and "ptp_cfg_active" with "ccc_gac". >> >> That's not exactly rename, no? At least for the 1st case... > > This is what we agreed as per last discussion[1]. > > https://patchwork.kernel.org/project/linux-renesas-soc/patch/20210825070154.14336-5-biju.das.jz@xxxxxxxxxxxxxx/ Sorry, I've changed my mind about 'no_gpgp' after seeing all the checks. I'd like to avoiud the double negations in those checks -- this should make the code more clear. My 1st idea (just 'gp[tp') turned out to be more practical, sorry about this going back-and-forth. :-< [...] MBR, Sergey