On 9/23/21 5:07 PM, Biju Das wrote:
> Rename the variable "no_ptp_cfg_active" with "no_gptp" with inverted
> checks and "ptp_cfg_active" with "ccc_gac".
That's not exactly rename, no? At least for the 1st case...
> There is no functional change.
>
> Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> Suggested-by: Sergey Shtylyov <s.shtylyov@xxxxxx>
> ---
> drivers/net/ethernet/renesas/ravb.h | 4 ++--
> drivers/net/ethernet/renesas/ravb_main.c | 25 ++++++++++++------------
> 2 files changed, 14 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/net/ethernet/renesas/ravb.h b/drivers/net/ethernet/renesas/ravb.h
> index 7363abae6e59..0ce0c13ef8cb 100644
> --- a/drivers/net/ethernet/renesas/ravb.h
> +++ b/drivers/net/ethernet/renesas/ravb.h
> @@ -1000,8 +1000,8 @@ struct ravb_hw_info {
> unsigned internal_delay:1; /* AVB-DMAC has internal delays */
> unsigned tx_counters:1; /* E-MAC has TX counters */
> unsigned multi_irqs:1; /* AVB-DMAC and E-MAC has multiple irqs */
> - unsigned no_ptp_cfg_active:1; /* AVB-DMAC does not support gPTP active in config mode */
> - unsigned ptp_cfg_active:1; /* AVB-DMAC has gPTP support active in config mode */
> + unsigned no_gptp:1; /* AVB-DMAC does not support gPTP feature */
Judging on the flag usage (which ensues using logical not in every case), I'd suggest to
invert this flag and call it 'gptp'...
[...]
MBR, Sergey
