Hi Sergei, Thanks for the feedback. > Subject: Re: [PATCH net-next 12/13] ravb: Factorise ravb_emac_init > function > > On 8/25/21 10:01 AM, Biju Das wrote: > > > The E-MAC IP on the R-Car AVB module has different initialization > > parameters for RX frame size, duplex settings, different offset for > > transfer speed setting and has magic packet detection support compared > > to E-MAC on RZ/G2L Gigabit Ethernet module. Factorise the > > ravb_emac_init function to support the later SoC. > > Again, couldn't we resolve these differencies like the sh_eth driver > does, by adding the register values into the *struct* ravb_hw_info? I will evaluate your proposal in terms of code size and data size And with the current code and share the details in next RFC patchset for supporting RZ/G2L with emac_init function. Based on the RFC discussion, we can conclude it. Currently by looking at your proposal, I am seeing duplication of Data in R-Car Gen3 and R-Car Gen2. Multiple if statement for handling duplex, initialising CSR0(Checksum operating mode register), CXR31(In-band status register) Regards, Biju > > > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > [...] > > MBR, Sergey
