On 8/25/21 10:01 AM, Biju Das wrote: > The E-MAC IP on the R-Car AVB module has different initialization > parameters for RX frame size, duplex settings, different offset > for transfer speed setting and has magic packet detection support > compared to E-MAC on RZ/G2L Gigabit Ethernet module. Factorise > the ravb_emac_init function to support the later SoC. Again, couldn't we resolve these differencies like the sh_eth driver does, by adding the register values into the *struct* ravb_hw_info? > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> [...] MBR, Sergey