Hi Morimoto-san, On Mon, May 24, 2021 at 7:43 AM Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> wrote: > > Please use numerical sort order when adding nodes with unit addresses. > > It seems r8a77995.dtsi numerical sort order is already broken. > Or am I misunderstanding ? > > ... > ipmmu_vi0: iommu@febd0000 > ipmmu_vp0: iommu@fe990000 > => avb: ethernet@e6800000 > => can0: can@e6c30000 > ---- and ore ---- We use numerical sort order, but group similar entries together. I.e. all iommu nodes are together, and their position is determined by the unit address of the first iommu node. I really should write a script to automate sorting, and propose that as the gold standard... Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds