Hi Geert > > From: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> > > > > This patch adds R-Car Sound and Audio-DMAC support for D3. > > > > 1st note is that D3 doesn't have audio-clk-c, but is > > required from driver. This patch uses null-clk for it. > > > > 2nd note is that D3 has SSI3/4 and SRC5/6 only, but driver > > requres from SSI0/SRC0. This patch has disabled SSI/SRC for it. > > I think it would be better to fix the driver instead. We already have this kind of SoC before. And I guess it has these, but just not counnected. It is Hardware side condition. > > + /* > > + * R8A77995 doesn't have audio_clk_c, * but is required from driver. > > + * Create NULL clock for it. > > + */ > > + null_clk: null_clk { > > + compatible = "fixed-clock"; > > + #clock-cells = <0>; > > + clock-frequency = <0>; > > + }; > > Please do not add nodes not matching the hardware description, but fix > the driver instead. ("DT describes hardware, not software policy"). Yeah, I agree. Will fix driver first, and repost SoC patch, again. Thank you for your help !! Best regards --- Kuninori Morimoto