Hi Uli, On Tue, Dec 22, 2020 at 5:51 PM Ulrich Hecht <uli@xxxxxxxx> wrote: > > On 12/22/2020 11:45 AM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > > > --- a/drivers/pinctrl/renesas/pinctrl.c > > > +++ b/drivers/pinctrl/renesas/pinctrl.c > > > + const struct sh_pfc_pin *pin = &pfc->info->pins[idx]; > > > + int lower_voltage; > > > > unsigned int > > Fair enough... > > > mV_low? > > That, though, seems ambiguous to me because it could refer to the logical-zero voltage. True. > (Are internal capital letters even permitted in identifiers?) We already have "mV". Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds