> On 12/22/2020 11:45 AM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
> > --- a/drivers/pinctrl/renesas/pinctrl.c
> > +++ b/drivers/pinctrl/renesas/pinctrl.c
> > @@ -634,6 +634,9 @@ static int sh_pfc_pinconf_get(struct pinctrl_dev *pctldev, unsigned _pin,
> > }
> >
> > case PIN_CONFIG_POWER_SOURCE: {
> > + int idx = sh_pfc_get_pin_index(pfc, _pin);
>
> I guess this cannot fail when we get here?
That would require a bug elsewhere, I think.
> > + const struct sh_pfc_pin *pin = &pfc->info->pins[idx];
> > + int lower_voltage;
>
> unsigned int
Fair enough...
> mV_low?
That, though, seems ambiguous to me because it could refer to the logical-zero voltage.
(Are internal capital letters even permitted in identifiers?)
CU
Uli
