Re: [PATCH 2/7] ARM: shmobile: r8a7779: Use ioremap() to map INTC2 registers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Arnd,

On Tue, Nov 17, 2020 at 1:25 PM Arnd Bergmann <arnd@xxxxxxxxxx> wrote:
> On Tue, Nov 17, 2020 at 11:30 AM Geert Uytterhoeven
> <geert+renesas@xxxxxxxxx> wrote:
> > Replace using the legacy IOMEM() macro to map various registers related
> > to INTC2 configuration by ioremap().
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>
> The patch looks good, but since you are already touching these __raw_writel(),
> could you turn them into normal writel() to have a chance that this works
> on big-endian? It could be either a follow-up or merged into the same patch.

(Do you want us to support big-endian on these old platforms? ;-)

At your service. Seems to work well.

Note that there are a few more (arch/arm/mach-shmobile/platsmp-scu.c
and arch/arm/mach-shmobile/setup-r8a7778.c).

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux