Re: [PATCH 2/7] ARM: shmobile: r8a7779: Use ioremap() to map INTC2 registers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 17, 2020 at 11:30 AM Geert Uytterhoeven
<geert+renesas@xxxxxxxxx> wrote:
>
> Replace using the legacy IOMEM() macro to map various registers related
> to INTC2 configuration by ioremap().
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

The patch looks good, but since you are already touching these __raw_writel(),
could you turn them into normal writel() to have a chance that this works
on big-endian? It could be either a follow-up or merged into the same patch.

       Arnd



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux