Hi Geert, > Subject: Re: [PATCH] ARM: dts: iwg20d-q7-common: Fix touch controller > probe failure > > Hi Biju, > > On Thu, Sep 24, 2020 at 11:40 AM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > wrote: > > > Subject: Re: [PATCH] ARM: dts: iwg20d-q7-common: Fix touch > > > controller probe failure On Thu, Sep 24, 2020 at 10:05 AM Biju Das > > > <biju.das.jz@xxxxxxxxxxxxxx> > > > wrote: > > > > As per the iWave RZ/G1M schematic, the signal LVDS_PPEN controls > > > > supply voltage for touch panel, LVDS receiver and RGB LCD panel. > > > > Add regulator for these device nodes and remove powerdown-gpios > > > > property from lvds-receiver node as it results in touch controller driver > probe failure. > > > > > > > > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > > > > Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > > > --- > > > > v4->v5 : Restored Laurent's Rb tag, since it is minor change, > > > > v4->renaming vcc-supply to power-supply > > > > > > > > v3->v4 : Incorporated Laurent's review > > > > v3->comments(https://patchwork.kernel.org/patch/11707887/) > > > > Added Laurent's Reviewed-by tag > > > > v2->v3 : Added the missing part from the patch. removal of > > > > v2->powerdown- > > > gpios property. > > > > v1->v2 : Add regulator in touch panel, LVDS receiver and RGB LCD > > > > v1->panel device nodes > > > > (Ref: https://patchwork.kernel.org/patch/11707559/) > > > > v1 : https://patchwork.kernel.org/patch/11705819/ > > > > > > Thanks for the update! > > > > > > As the prerequisites are now in next, I can queue this in > > > renesas-devel for > > > v5.11 after v5.10-rc1 has been released. > > > Or do you think this should be fast-tracked as a fix for v5.10 or v5.9? > > > > I think it should be fast tracked, since it is a regression. Also we need to fast > track the dependency patches as well. > > OK. > > > Fixes: 6f89dd9e9325 ("ARM: dts: iwg20d-q7-common: Add LCD support") > > [1] > > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/co > > mmit/?h=next-20200923&id=946a61ab2d758cc645f6e63f1a5e2731690c3943 > > [2] > > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/co > > mmit/?h=next-20200923&id=2cd9df2be75766452fef87c37ec37d91f4cbaf6b > > Does anything bad (e.g. another regression) happen if this patch is applied, > but the 2 patches above are not? > If not, I will queue this as a fix for v5.9. It works without that 2 patches, I confirm no side effects. root@iwg20m-g1m:~# dmesg | grep edt root@iwg20m-g1m:~# dmesg | grep input0 [ 2.386156] input: EP0700M06 as /devices/platform/soc/e6530000.i2c/i2c-0/0-0038/input/input0 root@iwg20m-g1m:~# root@iwg20m-g1m:~# uname -a Linux iwg20m-g1m 5.9.0-rc1-00003-g58dba537f8cb #64 SMP Thu Sep 24 13:00:42 BST 2020 armv7l GNU/Linux > > > > I.e. is this an actual regression, or just something that never worked > before? > > > Note that v1 had a Fixes tag, which was lost in subsequent versions. > > > > I missed to add fixes tag in subsequent versions. > > Fixes: 6f89dd9e9325 ("ARM: dts: iwg20d-q7-common: Add LCD support") > > No worries, I can add that while applying. Thank you. Cheers, Biju Renesas Electronics Europe GmbH, Geschaeftsfuehrer/President: Carsten Jauch, Sitz der Gesellschaft/Registered office: Duesseldorf, Arcadiastrasse 10, 40472 Duesseldorf, Germany, Handelsregister/Commercial Register: Duesseldorf, HRB 3708 USt-IDNr./Tax identification no.: DE 119353406 WEEE-Reg.-Nr./WEEE reg. no.: DE 14978647
