Hi Biju, On Thu, Sep 24, 2020 at 11:40 AM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote: > > Subject: Re: [PATCH] ARM: dts: iwg20d-q7-common: Fix touch controller > > probe failure > > On Thu, Sep 24, 2020 at 10:05 AM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > > wrote: > > > As per the iWave RZ/G1M schematic, the signal LVDS_PPEN controls > > > supply voltage for touch panel, LVDS receiver and RGB LCD panel. Add > > > regulator for these device nodes and remove powerdown-gpios property > > > from lvds-receiver node as it results in touch controller driver probe failure. > > > > > > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > > > Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > > --- > > > v4->v5 : Restored Laurent's Rb tag, since it is minor change, renaming > > > v4->vcc-supply to power-supply > > > > > > v3->v4 : Incorporated Laurent's review > > > v3->comments(https://patchwork.kernel.org/patch/11707887/) > > > Added Laurent's Reviewed-by tag > > > v2->v3 : Added the missing part from the patch. removal of powerdown- > > gpios property. > > > v1->v2 : Add regulator in touch panel, LVDS receiver and RGB LCD panel > > > v1->device nodes > > > (Ref: https://patchwork.kernel.org/patch/11707559/) > > > v1 : https://patchwork.kernel.org/patch/11705819/ > > > > Thanks for the update! > > > > As the prerequisites are now in next, I can queue this in renesas-devel for > > v5.11 after v5.10-rc1 has been released. > > Or do you think this should be fast-tracked as a fix for v5.10 or v5.9? > > I think it should be fast tracked, since it is a regression. Also we need to fast track the dependency patches as well. OK. > Fixes: 6f89dd9e9325 ("ARM: dts: iwg20d-q7-common: Add LCD support") > [1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=next-20200923&id=946a61ab2d758cc645f6e63f1a5e2731690c3943 > [2] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=next-20200923&id=2cd9df2be75766452fef87c37ec37d91f4cbaf6b Does anything bad (e.g. another regression) happen if this patch is applied, but the 2 patches above are not? If not, I will queue this as a fix for v5.9. > > I.e. is this an actual regression, or just something that never worked before? > > Note that v1 had a Fixes tag, which was lost in subsequent versions. > > I missed to add fixes tag in subsequent versions. > Fixes: 6f89dd9e9325 ("ARM: dts: iwg20d-q7-common: Add LCD support") No worries, I can add that while applying. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
