Hi Morimoto-san,
On Thu, Aug 6, 2020 at 2:12 AM Kuninori Morimoto
<kuninori.morimoto.gx@xxxxxxxxxxx> wrote:
> > > config ARCH_R8A774A1
> > > - bool "Renesas RZ/G2M SoC Platform"
> > > + bool "SoC Platform support for RZ/G2M"
> > > select ARCH_RCAR_GEN3
> > > select SYSC_R8A774A1
> > > help
> > > This enables support for the Renesas RZ/G2M SoC.
> > >
> > > config ARCH_R8A774B1
> > > - bool "Renesas RZ/G2N SoC Platform"
> > > + bool "SoC Platform support for RZ/G2N"
> >
> > [...]
> >
> > Why these changes?
>
> Because if this patch was applied, these are under "Renesas" menu.
OK, and you want the SoC name last, for easier reading?
> > > # SoC
> > > config SYSC_R8A7743
> > > - bool "RZ/G1M System Controller support" if COMPILE_TEST
> > > + bool "System Controller support for RZ/G1M" if COMPILE_TEST
> > > select SYSC_RCAR
> > >
> > > config SYSC_R8A7745
> > > - bool "RZ/G1E System Controller support" if COMPILE_TEST
> > > + bool "System Controller support for RZ/G1E" if COMPILE_TEST
> >
> > [...]
> >
> > Why these changes?
>
> Because of good looking.
>
> - R-Car H2 System Controller support
> - R-Car M2-W/N System Controller support
> - R-Car V2H System Controller support
> - R-Car E2 System Controller support
>
> + System Controller support for R-Car H2
> + System Controller support for R-Car M2-W/N
> + System Controller support for R-Car V2H
> + System Controller support for R-Car E2
I see, easier reading, too.
> > BTW, if you want to increase consistency, please also update the
> > descriptions for arm32 and family-specific options.
>
> Sorry I don't understand this.
> what does "arm32 and family-specific options" mean ?
I mean the other options in drivers/soc/renesas/Kconfig:
1. The arm32 SoCs are at the top, protected by "if ARM &&
ARCH_RENESAS", and also under the "Renesas" menu,
2. The family-specific options (R-Car/R-Mobile Reset/System Controller)
are at the bottom, and part of the same menu.
If you change any, it would be good to have consistent descriptions for
all of these.
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
