Hi Morimoto-san,
On Tue, Aug 4, 2020 at 8:12 AM Kuninori Morimoto
<kuninori.morimoto.gx@xxxxxxxxxxx> wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
>
> Renesas related SoC settings are located on TOP level menu
> when menuconfig, thus it is very verbose.
> This patch groups Renesas related settings into
> "Renesas SoC driver support" menu.
>
> And it aligns config menu names.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
Thanks for your patch!
Unfortunately it doesn't apply against renesas-devel, as new SoCs have
been added.
> --- a/drivers/soc/renesas/Kconfig
> +++ b/drivers/soc/renesas/Kconfig
> @@ -1,5 +1,5 @@
> # SPDX-License-Identifier: GPL-2.0
> -config SOC_RENESAS
> +menuconfig SOC_RENESAS
Yes, that helps.
> bool "Renesas SoC driver support" if COMPILE_TEST && !ARCH_RENESAS
> default y if ARCH_RENESAS
> select SOC_BUS
> @@ -174,35 +174,35 @@ endif # ARM
> if ARM64
>
> config ARCH_R8A774A1
> - bool "Renesas RZ/G2M SoC Platform"
> + bool "SoC Platform support for RZ/G2M"
> select ARCH_RCAR_GEN3
> select SYSC_R8A774A1
> help
> This enables support for the Renesas RZ/G2M SoC.
>
> config ARCH_R8A774B1
> - bool "Renesas RZ/G2N SoC Platform"
> + bool "SoC Platform support for RZ/G2N"
[...]
Why these changes?
> @@ -262,79 +262,79 @@ endif # ARM64
>
> # SoC
> config SYSC_R8A7743
> - bool "RZ/G1M System Controller support" if COMPILE_TEST
> + bool "System Controller support for RZ/G1M" if COMPILE_TEST
> select SYSC_RCAR
>
> config SYSC_R8A7745
> - bool "RZ/G1E System Controller support" if COMPILE_TEST
> + bool "System Controller support for RZ/G1E" if COMPILE_TEST
[...]
Why these changes?
BTW, if you want to increase consistency, please also update the
descriptions for arm32 and family-specific options.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
