Re: [PATCH] soc: renesas: use menu for Renesas SoC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert

Thank you for your review

> Thanks for your patch!
> Unfortunately it doesn't apply against renesas-devel, as new SoCs have
> been added.

OK, I will re-post after your reply.


> >  config ARCH_R8A774A1
> > -       bool "Renesas RZ/G2M SoC Platform"
> > +       bool "SoC Platform support for RZ/G2M"
> >         select ARCH_RCAR_GEN3
> >         select SYSC_R8A774A1
> >         help
> >           This enables support for the Renesas RZ/G2M SoC.
> >
> >  config ARCH_R8A774B1
> > -       bool "Renesas RZ/G2N SoC Platform"
> > +       bool "SoC Platform support for RZ/G2N"
> 
> [...]
> 
> Why these changes?

Because if this patch was applied, these are under "Renesas" menu.

> >  # SoC
> >  config SYSC_R8A7743
> > -       bool "RZ/G1M System Controller support" if COMPILE_TEST
> > +       bool "System Controller support for RZ/G1M" if COMPILE_TEST
> >         select SYSC_RCAR
> >
> >  config SYSC_R8A7745
> > -       bool "RZ/G1E System Controller support" if COMPILE_TEST
> > +       bool "System Controller support for RZ/G1E" if COMPILE_TEST
> 
> [...]
> 
> Why these changes?

Because of good looking.

	- R-Car H2 System Controller support
	- R-Car M2-W/N System Controller support
	- R-Car V2H System Controller support
	- R-Car E2 System Controller support

	+ System Controller support for R-Car H2
	+ System Controller support for R-Car M2-W/N
	+ System Controller support for R-Car V2H
	+ System Controller support for R-Car E2

> BTW, if you want to increase consistency, please also update the
> descriptions for arm32 and family-specific options.

Sorry I don't understand this.
what does "arm32 and family-specific options" mean ?

Thank you for your help !!

Best regards
---
Kuninori Morimoto



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux