On Tue, Jun 25, 2019 at 9:23 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > > Hi Olof, > > On Tue, Jun 25, 2019 at 3:10 PM Olof Johansson <olof@xxxxxxxxx> wrote: > > On Fri, Jun 21, 2019 at 11:12:04AM +0200, Simon Horman wrote: > > > Oleksandr Tyshchenko (1): > > > ARM: mach-shmobile: Don't init CNTVOFF/counter if PSCI is available > > > > Merged, thanks. > > Thanks! > > > Note that in this patch, code like this: > > > > +#ifdef CONFIG_ARM_PSCI_FW > > + if (psci_ops.cpu_on) > > + need_update = false; > > +#endif > > + > > + if (need_update == false) > > + goto skip_update; > > > > > > Can either be replaced with a goto under the ifdef, or at the very least, no > > I believe a goto under the ifdef may cause a "label defined but not used" > warning if CONFIG_ARM_PSCI_FW is not defined. Ah yeah, good point. -Olof
