Hi Olof,
On Tue, Jun 25, 2019 at 3:10 PM Olof Johansson <olof@xxxxxxxxx> wrote:
> On Fri, Jun 21, 2019 at 11:12:04AM +0200, Simon Horman wrote:
> > Oleksandr Tyshchenko (1):
> > ARM: mach-shmobile: Don't init CNTVOFF/counter if PSCI is available
>
> Merged, thanks.
Thanks!
> Note that in this patch, code like this:
>
> +#ifdef CONFIG_ARM_PSCI_FW
> + if (psci_ops.cpu_on)
> + need_update = false;
> +#endif
> +
> + if (need_update == false)
> + goto skip_update;
>
>
> Can either be replaced with a goto under the ifdef, or at the very least, no
I believe a goto under the ifdef may cause a "label defined but not used"
warning if CONFIG_ARM_PSCI_FW is not defined.
> need to do a 'need_update == false' -- 'if (need_update)' is sufficient.
Yeah, "if (!need_update)" would work too.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
