On 3/17/19 11:22 AM, Geert Uytterhoeven wrote:
> Hi Marek,
Hi,
> On Sun, Mar 17, 2019 at 1:06 AM Marek Vasut <marek.vasut@xxxxxxxxx> wrote:
>> On 3/11/19 10:41 AM, Geert Uytterhoeven wrote:
>>> On Sat, Mar 9, 2019 at 1:56 AM <marek.vasut@xxxxxxxxx> wrote:
>>>> --- a/drivers/pci/controller/pcie-rcar.c
>>>> +++ b/drivers/pci/controller/pcie-rcar.c
>>>> @@ -152,14 +152,12 @@ struct rcar_pcie {
>>>> struct rcar_msi msi;
>>>> };
>>>>
>>>> -static void rcar_pci_write_reg(struct rcar_pcie *pcie, unsigned long val,
>>>> - unsigned long reg)
>>>> +static void rcar_pci_write_reg(struct rcar_pcie *pcie, u32 val, u32 reg)
>>>
>>> Doesn't unsigned int make more sense for reg?
>>
>> Isn't u32 more explicit ?
>
> It's just an offset in the register block, with a range much smaller than u32.
We could use u16 ? However, Bjorn's concern was that using unsigned long
for registers was not recommended ; how's unsigned int better ?
--
Best regards,
Marek Vasut
