On 3/17/19 10:09 AM, Wolfram Sang wrote: > On Sun, Mar 17, 2019 at 01:06:06AM +0100, marek.vasut@xxxxxxxxx wrote: >> From: Marek Vasut <marek.vasut+renesas@xxxxxxxxx> >> >> Replace unsigned long with u32 type for variables holding > > s/unsigned long/various variable types/ Fixed >> register values, since the registers are 32bit. Note that >> rcar_pcie_msi_irq() still uses unsigned long because both >> find_first_bit() and __fls() require unsigned long as an >> argument. >> >> Signed-off-by: Marek Vasut <marek.vasut+renesas@xxxxxxxxx> > ... > >> - int shift = 8 * (where & 3); >> + u32 shift = 8 * (where & 3); > > Minor nit: Since this is about shifting, maybe replace 8 with << 3 while > we are here? > > There is also a 'shift' var in rcar_pcie_write_conf(). I think we should > convert this for consistency, too? OK, I might as well collect this and the other cleanup series and repost it together as a V2 to make it easier to pick. -- Best regards, Marek Vasut
