On 3/11/19 10:41 AM, Geert Uytterhoeven wrote:
> Hi Marek,
>
> On Sat, Mar 9, 2019 at 1:56 AM <marek.vasut@xxxxxxxxx> wrote:
>> From: Marek Vasut <marek.vasut+renesas@xxxxxxxxx>
>>
>> Replace unsigned long with u32 in register accessor functions,
>> since they access 32bit registers.
>>
>> Signed-off-by: Marek Vasut <marek.vasut+renesas@xxxxxxxxx>
>
> Thanks for your patch!
>
> Minor nit below.
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>
> BTW, there are a few more suspicious/incorrect uses of unsigned long:
> - incorrect debug prints on arm64,
> - more unsigned long register values,
> - phys_addr_t
> Care to fix these as well?
I'll send those shortly, as a separate series since they don't conflict
with each other.
> Thanks!
>
>> --- a/drivers/pci/controller/pcie-rcar.c
>> +++ b/drivers/pci/controller/pcie-rcar.c
>> @@ -152,14 +152,12 @@ struct rcar_pcie {
>> struct rcar_msi msi;
>> };
>>
>> -static void rcar_pci_write_reg(struct rcar_pcie *pcie, unsigned long val,
>> - unsigned long reg)
>> +static void rcar_pci_write_reg(struct rcar_pcie *pcie, u32 val, u32 reg)
>
> Doesn't unsigned int make more sense for reg?
Isn't u32 more explicit ?
--
Best regards,
Marek Vasut
