On Fri, Jan 18, 2019 at 12:58:55PM +0100, Geert Uytterhoeven wrote: > Hi Uli, > > On Fri, Jan 18, 2019 at 11:48 AM Ulrich Hecht <uli+renesas@xxxxxxxx> wrote: > > Based on Rev. 1.00 of the R-Car H1 datasheet. > > > > Signed-off-by: Ulrich Hecht <uli+renesas@xxxxxxxx> > > Thanks for the update! > > > --- a/arch/arm/boot/dts/r8a7779.dtsi > > +++ b/arch/arm/boot/dts/r8a7779.dtsi > > > + hscif1: serial@ffe49000 { > > + compatible = "renesas,hscif-r8a7779", > > + "renesas,rcar-gen1-hscif", "renesas,hscif"; > > + reg = <0xffe49000 96>; > > + interrupts = <GIC_SPI 95 IRQ_TYPE_LEVEL_HIGH>; > > + clocks = <&mstp0_clks R8A7779_CLK_HSCIF1, > > Missing closing ">". > > With the above fixed: > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> Thanks, applied with that fixed. Ulrich, do we need a patch to add the renesas,hscif-r8a7779 binding?