Hi Simon, On Fri, Jan 18, 2019 at 1:18 PM Simon Horman <horms@xxxxxxxxxxxx> wrote: > On Fri, Jan 18, 2019 at 12:58:55PM +0100, Geert Uytterhoeven wrote: > > On Fri, Jan 18, 2019 at 11:48 AM Ulrich Hecht <uli+renesas@xxxxxxxx> wrote: > > > --- a/arch/arm/boot/dts/r8a7779.dtsi > > > +++ b/arch/arm/boot/dts/r8a7779.dtsi > > > > > + hscif1: serial@ffe49000 { > > > + compatible = "renesas,hscif-r8a7779", > > > + "renesas,rcar-gen1-hscif", "renesas,hscif"; > > > + reg = <0xffe49000 96>; > > > + interrupts = <GIC_SPI 95 IRQ_TYPE_LEVEL_HIGH>; > > > + clocks = <&mstp0_clks R8A7779_CLK_HSCIF1, > > > > Missing closing ">". > > > > With the above fixed: > > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > > Thanks, applied with that fixed. Thanks! > Ulrich, do we need a patch to add the renesas,hscif-r8a7779 binding? I believe you were CCed by Greg's bot for patch "dt-bindings: serial: sh-sci: Document r8a7778/9 HSCIF bindings" added to tty-testing Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds