Hi Uli,
On Fri, Jan 18, 2019 at 11:48 AM Ulrich Hecht <uli+renesas@xxxxxxxx> wrote:
> Adds HSCIF0 and HSCIF1 pins, groups and functions for R8A7779.
>
> Signed-off-by: Ulrich Hecht <uli+renesas@xxxxxxxx>
Thanks for your patch!
> --- a/drivers/pinctrl/sh-pfc/pfc-r8a7779.c
> +++ b/drivers/pinctrl/sh-pfc/pfc-r8a7779.c
> @@ -1595,6 +1595,80 @@ static const unsigned int ether_magic_pins[] = {
> static const unsigned int ether_magic_mux[] = {
> ETH_MAGIC_MARK,
> };
> +/* - HSCIF0 ----------------------------------------------------------------- */
> +static const unsigned int hscif0_data_pins[] = {
> + RCAR_GP_PIN(4, 20), RCAR_GP_PIN(4, 21)
Can you please add TXD, RXD etc. comments, like are present for all other pin
groups?
> +static const unsigned int hscif1_b_clk_pins[] = {
error: ‘hscif1_clk_b_pins’ undeclared here
hscif1_clk_b_pins
> + RCAR_GP_PIN(2, 4)
> +};
> +static const unsigned int hscif1_b_clk_mux[] = {
hscif1_clk_b_mux
> + HSCK1_B_MARK
> +};
> /* - HSPI0 ------------------------------------------------------------------ */
> static const unsigned int hspi0_pins[] = {
> /* CLK, CS, RX, TX */
With the above fixed:
Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
