On 12/16/2018 09:08 PM, Geert Uytterhoeven wrote: [...] >>>>> Git actually does that automatically, assumed your user.email config matches >>>>> the From: address that is used in your outgoing email delivery path (i.e. the >>>>> scrubbed one, when using Gmail's SMTP server). >>>>> If you lie to git in your user.email config, git cannot do the right >>>>> thing, obviously. >>>> >>>> My git user.email obviously matches the From: field , before the >>>> scrubbing, which I believe is the correct thing to do. >>> >>> I disagree, because that is not how the emails are actually going out from the >>> SMTP server you are using. >> >> Can you summarize, clearly, what you believe is the right thing to >> configure and where ? > > According to git-send-email(1), you can either pass your scrubbed email > address to --from, or configure it in the sendemail.from config option. > Does that work for you? So sendemail.from != user.email , the later has the +tag while the former does not ? >>>>>> from the same person/email address as the email address in From, so they >>>>>> are equal. >>>>> >>>>> If they differ, they are not equal ;-) >>>> >>>> Depends on how you define 'equal' . Here I think foo+bar@xxxxxxxxxxx >>>> should be considered equal to foo@xxxxxxxxxxx . >>> >>> That is domain-specific knowledge, which you cannot rely upon. > >>>> Aha, so maybe that enhancement needs further enhancement to scrub the >>>> +tags before the check ? >>> >>> Again, that is domain-specific knowledge, which you cannot rely upon. >> >> How so, please elaborate . > > In general, you cannot assume the "+foo" part can be ignored. Only the sender > knows. How so ? -- Best regards, Marek Vasut
