On 12/15/2018 09:00 PM, Geert Uytterhoeven wrote: > Hi Marek, > > On Sat, Dec 15, 2018 at 8:07 PM Marek Vasut <marek.vasut@xxxxxxxxx> wrote: >> On 12/15/2018 07:54 PM, Geert Uytterhoeven wrote: >>> On Sat, Dec 15, 2018 at 7:49 PM Marek Vasut <marek.vasut@xxxxxxxxx> wrote: >>>> On 12/15/2018 07:47 PM, Geert Uytterhoeven wrote: >>>>> On Sat, Dec 15, 2018 at 7:38 PM Marek Vasut <marek.vasut@xxxxxxxxx> wrote: >>>>>> On 12/15/2018 06:23 PM, Eduardo Valentin wrote: >>>>>>> On Wed, Dec 12, 2018 at 02:49:22AM +0100, Marek Vasut wrote: >>>>>>>> Introduce new thermal_zone_of_sensor_register_params() function, which >>>>>>>> allows passing struct thermal_zone_params into it and convert original >>>>>>>> thermal_zone_of_sensor_register() to call it with params set to NULL. >>>>>>>> >>>>>>>> Signed-off-by: Marek Vasut <marek.vasut+renesas@xxxxxxxxx> >>>>>>> >>>>>>> Git complains about mismatch between From: and this SOB. >>>>>> >>>>>> I recall a discussion about gmail stripping the +foo tags from email >>>>>> addresses. I can add a From: tag into the patch to override this >>>>>> braindeath, or is there a better solution ? >>>>> >>>>> Run the "git format-patch" command from a git repo where user.email >>>>> is marek.vasut@xxxxxxxxx, so it will retain the original From: tag in the >>>>> email body, as it is different? >>>> >>>> I can also manually patch the From tags or add them, but it's all >>>> workarounds. >>> >>> Use a different outgoing email server? I use my ISP's. >> >> Or maybe it'd make sense to fix git to handle the +tags correctly ? > > What needs to be fixed? > If user.email != From, git format-patch generates a From: header, else > it doesn't. Doesn't that make sense? I believe the complaint here is that email address in From does not match email address in SoB line, because some SMTP servers scrub the +foo tag from From: and not from SoB-line . And yet, the SoB line is from the same person/email address as the email address in From, so they are equal. I think git should just ignore the +foo tag in SoB line. -- Best regards, Marek Vasut
