Re: [PATCH 1/2] arm64: dts: r8a77965: add FDP1 device nodes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Aug 28, 2018 at 12:56:18PM +0300, Laurent Pinchart wrote:
> Hi Simon,
> 
> On Monday, 27 August 2018 15:57:05 EEST Simon Horman wrote:
> > On Fri, Aug 24, 2018 at 11:45:52AM +0300, Laurent Pinchart wrote:
> > > On Friday, 24 August 2018 07:52:28 EEST Nguyen An Hoan wrote:
> > > > From: Hoan Nguyen An <na-hoan@xxxxxxxxxxx>
> > > 
> > > You're missing a commit message. I agree that for simple patches like this
> > > one the subject line often contains enough information, but adding a
> > > commit message is still a good practice that we try to enforce through
> > > the kernel. For instance, looking at git history for r8a7796, you could
> > > use
> > > 
> > > "The r8a77965 has a single FDP1 instance."
> > > 
> > > > Signed-off-by: Hoan Nguyen An <na-hoan@xxxxxxxxxxx>
> > > 
> > > Apart from that,
> > > 
> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> > > 
> > > Simon, could you update the commit message when taking this patch in your
> > > tree, to avoid the need for a v2 ?
> > 
> > Yes, can do.
> > 
> > Can I confirm that it is safe, from a regression point of view,
> > to apply this patch without patch 2/2?
> 
> As far as I know it is safe, yes.

Thanks, applied for v4.20.



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux