Hello Nguyen An,
Thank you for the patch.
On Friday, 24 August 2018 07:52:28 EEST Nguyen An Hoan wrote:
> From: Hoan Nguyen An <na-hoan@xxxxxxxxxxx>
You're missing a commit message. I agree that for simple patches like this one
the subject line often contains enough information, but adding a commit
message is still a good practice that we try to enforce through the kernel.
For instance, looking at git history for r8a7796, you could use
"The r8a77965 has a single FDP1 instance."
> Signed-off-by: Hoan Nguyen An <na-hoan@xxxxxxxxxxx>
Apart from that,
Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
Simon, could you update the commit message when taking this patch in your
tree, to avoid the need for a v2 ?
> ---
> arch/arm64/boot/dts/renesas/r8a77965.dtsi | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> b/arch/arm64/boot/dts/renesas/r8a77965.dtsi index 9c4f405..bef519f 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
> @@ -1578,6 +1578,16 @@
> status = "disabled";
> };
>
> + fdp1@fe940000 {
> + compatible = "renesas,fdp1";
> + reg = <0 0xfe940000 0 0x2400>;
> + interrupts = <GIC_SPI 262 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cpg CPG_MOD 119>;
> + power-domains = <&sysc R8A77965_PD_A3VP>;
> + resets = <&cpg 119>;
> + renesas,fcp = <&fcpf0>;
> + };
> +
> fcpf0: fcp@fe950000 {
> compatible = "renesas,fcpf";
> reg = <0 0xfe950000 0 0x200>;
--
Regards,
Laurent Pinchart
