Re: [PATCH v2] arm64: dts: renesas: salvator-xs: enable SATA

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Wolfram,

On Tue, Aug 21, 2018 at 3:41 PM Wolfram Sang <wsa@xxxxxxxxxxxxx> wrote:
> > > +/* MD12 (SW12-7) must be set 'Off' which is not the default! */
> >
> > Upon reading this again, I think this comment is confusing: the 'Off' refers
> > to the switch position, not to the MD12 logic value, while the parentheses
> > suggest otherwise.
> >
> > What about the following?
> >
> >     SW12-7 must be set 'Off' (MD12 set to 1), which is not the default!
>
> I'd leave the ',' away but otherwise:
>
> Acked-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
>
> Shall I send an incremental patch or do you want to do it?

Sent, preacked ;-)

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux