Hi Wolfram, Simon,
On Mon, Jul 30, 2018 at 9:34 AM Wolfram Sang
<wsa+renesas@xxxxxxxxxxxxxxxxxxxx> wrote:
> Add the nodes to enable SATA. Note that MD12 (SW12-7) must be switched
> off for that to work.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> ---
>
> Changes since v1:
> * fixed indentation (Thanks, Geert!)
> * merged two patches into one (Thanks, Simon!)
> * Added Geert's tag
> --- a/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a7795-salvator-xs.dts
> @@ -176,6 +185,11 @@
> };
> };
>
> +/* MD12 (SW12-7) must be set 'Off' which is not the default! */
Upon reading this again, I think this comment is confusing: the 'Off' refers
to the switch position, not to the MD12 logic value, while the parentheses
suggest otherwise.
What about the following?
SW12-7 must be set 'Off' (MD12 set to 1), which is not the default!
> --- a/arch/arm64/boot/dts/renesas/r8a77965-salvator-xs.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a77965-salvator-xs.dts
> +/* MD12 (SW12-7) must be set 'Off' which is not the default! */
Likewise.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
