Re: [PATCH v2] arm64: dts: renesas: salvator-xs: enable SATA

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > +/* MD12 (SW12-7) must be set 'Off' which is not the default! */
> 
> Upon reading this again, I think this comment is confusing: the 'Off' refers
> to the switch position, not to the MD12 logic value, while the parentheses
> suggest otherwise.
> 
> What about the following?
> 
>     SW12-7 must be set 'Off' (MD12 set to 1), which is not the default!

I'd leave the ',' away but otherwise:

Acked-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>

Shall I send an incremental patch or do you want to do it?

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux