Hi Geert,
Thanks for the feedback.
> -----Original Message-----
> From: devicetree-owner@xxxxxxxxxxxxxxx <devicetree-
> owner@xxxxxxxxxxxxxxx> On Behalf Of Geert Uytterhoeven
> Sent: 03 August 2018 10:10
> To: Biju Das <biju.das@xxxxxxxxxxxxxx>
> Cc: Rob Herring <robh+dt@xxxxxxxxxx>; Mark Rutland
> <mark.rutland@xxxxxxx>; Simon Horman <horms@xxxxxxxxxxxx>; Magnus
> Damm <magnus.damm@xxxxxxxxx>; Linux-Renesas <linux-renesas-
> soc@xxxxxxxxxxxxxxx>; open list:OPEN FIRMWARE AND FLATTENED DEVICE
> TREE BINDINGS <devicetree@xxxxxxxxxxxxxxx>; Geert Uytterhoeven
> <geert+renesas@xxxxxxxxx>; Chris Paterson
> <Chris.Paterson2@xxxxxxxxxxx>; Fabrizio Castro
> <fabrizio.castro@xxxxxxxxxxxxxx>
> Subject: Re: [PATCH v2 3/5] ARM: dts: r8a77470: Add GPIO support
>
> Hi Biju,
>
> On Thu, Aug 2, 2018 at 4:17 PM Biju Das <biju.das@xxxxxxxxxxxxxx> wrote:
> > Describe GPIO blocks in the R8A77470 device tree.
> >
> > Signed-off-by: Biju Das <biju.das@xxxxxxxxxxxxxx>
> > Reviewed-by: Fabrizio Castro <fabrizio.castro@xxxxxxxxxxxxxx>
>
> Thanks for your patch!
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>
> > --- a/arch/arm/boot/dts/r8a77470.dtsi
> > +++ b/arch/arm/boot/dts/r8a77470.dtsi
>
> > + gpio3: gpio@e6053000 {
> > + compatible = "renesas,gpio-r8a77470",
> > + "renesas,rcar-gen2-gpio";
> > + reg = <0 0xe6053000 0 0x50>;
> > + interrupts = <GIC_SPI 7 IRQ_TYPE_LEVEL_HIGH>;
> > + #gpio-cells = <2>;
> > + gpio-controller;
> > + gpio-reserved-ranges = <17 10>;
> > + gpio-ranges = <&pfc 0 96 30>;
>
> I would reverse the order of these two properties, but that's purely
> cosmetic.
Will send V3 with this change.
Regards,
Biju
Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
