Re: [PATCH 1/3] mmc: tmio: Add initial setting of interrupt mask register

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Wolfram,

Thanks for your feedback.

On 2018-06-27 09:27:02 +0200, Wolfram Sang wrote:
> 
> > > > +#define TMIO_MASK_INIT          0x8b7f031d /* H/W initial value */
> > > 
> > > known on R-Car 2+ only!
> > 
> > No it's also know on Gen3 :-)
> 
> Sure, 2+ means "R-Car 2 and later". Like with GPL2+. Sorry if this was
> not clear. And it is still my main argument to do...

When you point it out it's clear, sorry I missed that.

> 
> > > So, we should at least protect this with TMIO_MMC_MIN_RCAR2, I'd think.
> > > Maybe we should even move it to renesas_sdhi_core.c, but I am not too
> > > sure about that.
> 
> ... this.
> 

I will look into this and send a new version :-)

-- 
Regards,
Niklas Söderlund



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux