On 27/06/18 17:40, Geert Uytterhoeven wrote:
> Hi Simon,
>
> On Wed, Jun 27, 2018 at 5:10 PM Simon Horman <horms@xxxxxxxxxxxx> wrote:
>> On Tue, Jun 26, 2018 at 01:57:47PM -0600, Rob Herring wrote:
>>> On Thu, Jun 14, 2018 at 03:48:08PM +0200, Geert Uytterhoeven wrote:
>>>> With recent dtc and W=1:
>>>>
>>>> ...salvator-x.dtb: Warning (graph_port): /soc/i2c@e66d8000/video-receiver@70/port@10: graph node unit address error, expected "a"
>>>> ...salvator-x.dtb: Warning (graph_port): /soc/i2c@e66d8000/video-receiver@70/port@11: graph node unit address error, expected "b"
>>>>
>>>> Unit addresses are always hexadecimal (without prefix), while the bases
>>>> of reg property values depend on their prefixes.
>>>>
>>>> Fixes: 908001d778eba06e ("arm64: dts: renesas: salvator-common: Add ADV7482 support")
>>>> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>>>> ---
>>>> arch/arm64/boot/dts/renesas/salvator-common.dtsi | 4 ++--
>>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> Reviewed-by: Rob Herring <robh@xxxxxxxxxx>
>>
>> Geert, shall I apply this?
>
> I'd say yes. Thanks!
I'm happy to throw an
Acked-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx>
on the patch - but I had a pending question regarding the reg = <10> part.
Shouldn't the reg become hex "reg = <0xa>" to be consistent?
Either way - if there's precedent - take that route and I'm happy.
--
Regards
Kieran
>
> Gr{oetje,eeting}s,
>
> Geert
>
