On 04 June 2018 19:32, Marek Vasut wrote, > Subject: Re: [PATCH v3 03/10] mfd: da9063: Rename PMIC_DA9063 to > PMIC_CHIP_ID_DA9063 > > On 06/04/2018 02:26 PM, Lee Jones wrote: > > On Sat, 02 Jun 2018, Marek Vasut wrote: > > > >> The PMIC_DA9063 is a complete misnomer, it denotes the value of the > >> DA9063 chip ID register, so rename it as such. It is also the value > >> of chip ID register of DA9063L though, so drop the enum as all the > >> DA9063 "models" share the same chip ID and thus the distinction will > >> have to be made using DT or otherwise. > >> > >> Signed-off-by: Marek Vasut <marek.vasut+renesas@xxxxxxxxx> > >> Cc: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > >> Cc: Lee Jones <lee.jones@xxxxxxxxxx> > >> Cc: Mark Brown <broonie@xxxxxxxxxx> > >> Cc: Steve Twiss <stwiss.opensource@xxxxxxxxxxx> > >> Cc: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> > >> Cc: linux-renesas-soc@xxxxxxxxxxxxxxx > >> Acked-by: Mark Brown <broonie@xxxxxxxxxx> > >> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > >> --- > >> V2: No change > >> V3: No change > >> --- > >> drivers/mfd/da9063-core.c | 2 +- > >> drivers/mfd/da9063-i2c.c | 2 +- > >> drivers/regulator/da9063-regulator.c | 2 +- > >> include/linux/mfd/da9063/core.h | 4 +--- > >> 4 files changed, 4 insertions(+), 6 deletions(-) > > > > For my own reference: > > Acked-for-MFD-by: Lee Jones <lee.jones@xxxxxxxxxx> > > Thanks. > > Any other comments before I submit the next round in a few days? > Hi Marek, Thanks. I'm reviewing it now. Could you hold off until tomorrow please? Regards, Steve
