Hi Uli, On Fri, Dec 15, 2017 at 4:14 PM, Ulrich Hecht <ulrich.hecht+renesas@xxxxxxxxx> wrote: > From: Takeshi Kihara <takeshi.kihara.df@xxxxxxxxxxx> > > This patch adds ZG clock divider support for R-Car Gen3 SoC. > > Signed-off-by: Takeshi Kihara <takeshi.kihara.df@xxxxxxxxxxx> SoB? > --- a/drivers/clk/renesas/rcar-gen3-cpg.c > +++ b/drivers/clk/renesas/rcar-gen3-cpg.c > @@ -73,6 +73,8 @@ static void cpg_simple_notifier_register(struct raw_notifier_head *notifiers, > */ > #define CPG_FRQCRB 0x00000004 > #define CPG_FRQCRB_KICK BIT(31) > +#define CPG_FRQCRB_ZGFC_MASK (0x1f << 24) > +#define CPG_FRQCRB_ZGFC_SHIFT 24 > #define CPG_FRQCRC 0x000000e0 > #define CPG_FRQCRC_ZFC_MASK GENMASK(12, 8) > #define CPG_FRQCRC_Z2FC_MASK GENMASK(4, 0) > @@ -197,6 +199,120 @@ static struct clk * __init cpg_z_clk_register(const char *name, > return clk; > } > > +static unsigned long cpg_zg_clk_recalc_rate(struct clk_hw *hw, > + unsigned long parent_rate) > +{ I think this can be consolidated with the Z/Z2 clock support, like Simon did for the Z2 clock: https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git/commit/?h=topic/rcar-gen3-z-clk-v3&id=fda8dbe29dd1f04b61c443147a106962cf5d3f14 Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds