Re: [PATCH 3/4] arm64: dts: r8a7796: Add GSX device node

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Uli,

On Fri, Dec 15, 2017 at 4:14 PM, Ulrich Hecht
<ulrich.hecht+renesas@xxxxxxxxx> wrote:
> From: Takeshi Kihara <takeshi.kihara.df@xxxxxxxxxxx>
>
> This patch adds GSX device node for R8A7796 SoC.
>
> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@xxxxxxxxxxx>

SoB?

> --- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
> @@ -2241,6 +2241,14 @@
>                         };
>                 };
>
> +               gsx: gsx@fd000000 {

gpu@fd000000?

> +                       compatible = "renesas,gsx";

That compatible value sounds a bit simplistic to me.
In addition, it's not yet documented.

> +                       reg = <0 0xfd000000 0 0x3ffff>;

reg = <0 0xfd000000 0 0x40000>;

> +                       interrupts = <GIC_SPI 119 IRQ_TYPE_LEVEL_HIGH>;
> +                       clocks = <&cpg CPG_MOD 112>;

According to Figure 23.2, there's an incoming reset signal, but it's not
listed in Table 8A.28.

> +                       power-domains = <&sysc R8A7796_PD_3DG_B>;

iommus?

> +               };
> +
>                 pciec0: pcie@fe000000 {
>                         /* placeholder */
>                 };

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux