Hi Laurent, On Wed, Oct 18, 2017 at 2:16 PM, Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> wrote: > On Wednesday, 18 October 2017 12:33:47 EEST Biju Das wrote: >> From: Fabrizio Castro <fabrizio.castro@xxxxxxxxxxxxxx> >> >> Although there is a HDMI connector on the q7 carrier board it is not >> connected to the RZ/G1M SoC. One must use the HDMI connector on the >> camera daughter board. >> >> This patch adds support for this connector. >> >> Signed-off-by: Fabrizio Castro <fabrizio.castro@xxxxxxxxxxxxxx> >> Reviewed-by: Biju Das <biju.das@xxxxxxxxxxxxxx> >> --- a/arch/arm/boot/dts/iwg20d-q7-dbcm-ca.dtsi >> +++ b/arch/arm/boot/dts/iwg20d-q7-dbcm-ca.dtsi >> @@ -23,7 +48,57 @@ >> status = "okay"; >> }; >> >> +&i2c5 { >> + status = "okay"; >> + clock-frequency = <400000>; >> + >> + cec_clock: cec-clock { >> + compatible = "fixed-clock"; >> + #clock-cells = <0>; >> + clock-frequency = <12000000>; >> + }; > > I assume this describes a fixed clock generator that is not I2C-controlled. > The node should thus not be a child of the i2c5 bus node, but should be moved > to the root node of the DT. Oops, that's something we should fix in r8a7791-koelsch.dts, too (CC Hans) > The rest looks good to me. With this fixed, > > Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > However I can't find arch/arm/boot/dts/iwg20d-q7-dbcm-ca.dtsi in linux-next. > Which tree would you like to get this series merged through ? It's been in next as of next-20171012. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds