Hi Laurent, > On Wednesday, 18 October 2017 12:33:47 EEST Biju Das wrote: > > From: Fabrizio Castro <fabrizio.castro@xxxxxxxxxxxxxx> > > > > Although there is a HDMI connector on the q7 carrier board it is not > > connected to the RZ/G1M SoC. One must use the HDMI connector on the > > camera daughter board. > > > > This patch adds support for this connector. > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@xxxxxxxxxxxxxx> > > Reviewed-by: Biju Das <biju.das@xxxxxxxxxxxxxx> > > --- > > arch/arm/boot/dts/iwg20d-q7-dbcm-ca.dtsi | 75 > > +++++++++++++++++++++++++++++ > > 1 file changed, 75 insertions(+) > > > > diff --git a/arch/arm/boot/dts/iwg20d-q7-dbcm-ca.dtsi > > b/arch/arm/boot/dts/iwg20d-q7-dbcm-ca.dtsi index 31fab5f..45b8167 > > 100644 > > --- a/arch/arm/boot/dts/iwg20d-q7-dbcm-ca.dtsi > > +++ b/arch/arm/boot/dts/iwg20d-q7-dbcm-ca.dtsi > > +&i2c5 { > > +status = "okay"; > > +clock-frequency = <400000>; > > + > > +cec_clock: cec-clock { > > +compatible = "fixed-clock"; > > +#clock-cells = <0>; > > +clock-frequency = <12000000>; > > +}; > > I assume this describes a fixed clock generator that is not I2C-controlled. > The node should thus not be a child of the i2c5 bus node, but should be moved > to the root node of the DT. Thanks, We will send a v2 with above changes. > The rest looks good to me. With this fixed, > > Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > However I can't find arch/arm/boot/dts/iwg20d-q7-dbcm-ca.dtsi in linux-next. > Which tree would you like to get this series merged through ? Currently it is in renesas devel branch (https://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git). It will be merged with linux-next in coming weeks. Regards, Biju Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.