Hi Geert > >> > - audio_clka > >> > - audio_clkb > >> > + audio_clk_a > >> > + audio_clk_b > >> > >> It's debatable. > >> The datasheet uses "CLKA" and "CLKOUT", while the pinctrl drivers tend > >> to use "clk_a" (with underscore) and "clkout" (without underscore). > >> > >> Except for r8a7794, which uses the "clka" form. Oops... > >> As this is DT ABI, we cannot easily change it. But if you want, we can add > >> aliases. > > > > I have no strong opinion about this "clka" vs "clk_a". > > I will do nothing if you are OK on this current patch (= "clka"), > > I will post v2 patch if you say "clk_a" is good. > > I think it's best to follow what's done in the other R-Car Gen3 SoCs. > Else we may end up in trouble if a board shows up that can support both > R-Car D3 and another R-Car Gen3 SoC (cfr. Salvator-X(S) and ULCB > with R-Car H3 and M3-W). Yeah agree. But unfortunately, both "clka" / "clk_a" are already used, right ? I think we want to have "clk_a" ? Best regards --- Kuninori Morimoto
