Re: [RFC][PATCH 3/4] pinctrl: sh-pfc: r8a77995: add Audio clock pin support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert

> >  - audio_clka
> >  - audio_clkb
> >  + audio_clk_a
> >  + audio_clk_b
> 
> It's debatable.
> The datasheet uses "CLKA" and "CLKOUT", while the pinctrl drivers tend
> to use "clk_a" (with underscore) and "clkout" (without underscore).
> 
> Except for r8a7794, which uses the "clka" form. Oops...
> As this is DT ABI, we cannot easily change it. But if you want, we can add
> aliases.

I have no strong opinion about this "clka" vs "clk_a".
I will do nothing if you are OK on this current patch (= "clka"),
I will post v2 patch if you say "clk_a" is good.

Best regards
---
Kuninori Morimoto



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux