Re: [RFC][PATCH 3/4] pinctrl: sh-pfc: r8a77995: add Audio clock pin support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Morimoto-san,

On Tue, Oct 3, 2017 at 6:09 AM, Kuninori Morimoto
<kuninori.morimoto.gx@xxxxxxxxxxx> wrote:
>> From: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
>>
>> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
>> ---
> (snip)
>> +static const char * const audio_clk_groups[] = {
>> +     "audio_clka",
>> +     "audio_clkb",
>> +     "audio_clkout",
>> +     "audio_clkout1",
>> +};
>
> Oops, we want to have this ?
>
>  - audio_clka
>  - audio_clkb
>  + audio_clk_a
>  + audio_clk_b

It's debatable.
The datasheet uses "CLKA" and "CLKOUT", while the pinctrl drivers tend
to use "clk_a" (with underscore) and "clkout" (without underscore).

Except for r8a7794, which uses the "clka" form. Oops...
As this is DT ABI, we cannot easily change it. But if you want, we can add
aliases.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux