Re: [RFC][PATCH 4/4] pinctrl: sh-pfc: r8a77995: add Audio SSI pin support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Sergei, Morimoto-san,

On Tue, Oct 3, 2017 at 11:36 AM, Sergei Shtylyov
<sergei.shtylyov@xxxxxxxxxxxxxxxxxx> wrote:
> On 10/3/2017 5:23 AM, Kuninori Morimoto wrote:
>> From: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
>>
>> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
>> ---
>>   drivers/pinctrl/sh-pfc/pfc-r8a77995.c | 60
>> +++++++++++++++++++++++++++++++++++
>>   1 file changed, 60 insertions(+)
>>
>> diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a77995.c
>> b/drivers/pinctrl/sh-pfc/pfc-r8a77995.c
>> index 2b56253..1a5c5a7 100644
>> --- a/drivers/pinctrl/sh-pfc/pfc-r8a77995.c
>> +++ b/drivers/pinctrl/sh-pfc/pfc-r8a77995.c
>> @@ -1232,6 +1232,50 @@ enum {
>>         SCIF_CLK_MARK,
>>   };
>>   +/* - SSI
>> ---------------------------------------------------------------*/
>> +static const unsigned int ssi3_data_pins[] = {
>> +       /* SDATA3 */
>> +       RCAR_GP_PIN(4, 3),
>> +};
>> +static const unsigned int ssi3_data_mux[] = {
>> +       SSI_SDATA3_MARK,
>> +};
>> +static const unsigned int ssi34_ctrl_pins[] = {
>> +       /* SCK34,  WS34 */
>> +       RCAR_GP_PIN(4, 2), RCAR_GP_PIN(4, 4),
>> +};
>> +static const unsigned int ssi34_ctrl_mux[] = {
>> +       SSI_SCK34_MARK, SSI_WS34_MARK,
>> +};
>> +static const unsigned int ssi4_ctrl_a_pins[] = {
>> +       /* SCK4_A, WS4_A */
>
>
>    Why these sudden A/B suffixes in the comments?
> We haven't had them yet, I think.

Indeed. Other drivers don't even have the numerical suffixes, except for
R-Car H2 and E2.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux