On 06/29/2017 01:38 PM, Geert Uytterhoeven wrote: > Hi Marek, > > On Thu, Jun 29, 2017 at 12:18 PM, Marek Vasut <marek.vasut@xxxxxxxxx> wrote: >> From: Marek Vasut <marek.vasut+renesas@xxxxxxxxx> >> >> IDT VersaClock 6 5P49V6901 has 4 clock outputs, 4 fractional dividers. >> Input clock source can be taken from either external crystal or from >> external reference clock. >> >> Signed-off-by: Marek Vasut <marek.vasut+renesas@xxxxxxxxx> >> Cc: Alexey Firago <alexey_firago@xxxxxxxxxx> >> Cc: Rob Herring <robh@xxxxxxxxxx> >> Cc: Stephen Boyd <sboyd@xxxxxxxxxxxxxx> >> Cc: Michael Turquette <mturquette@xxxxxxxxxxxx> >> Cc: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> >> Cc: linux-renesas-soc@xxxxxxxxxxxxxxx >> Cc: devicetree@xxxxxxxxxxxxxxx >> --- >> .../devicetree/bindings/clock/idt,versaclock5.txt | 15 ++++++++++++--- >> 1 file changed, 12 insertions(+), 3 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/clock/idt,versaclock5.txt b/Documentation/devicetree/bindings/clock/idt,versaclock5.txt >> index 53d7e50ed875..a3d4260039a8 100644 >> --- a/Documentation/devicetree/bindings/clock/idt,versaclock5.txt >> +++ b/Documentation/devicetree/bindings/clock/idt,versaclock5.txt > > Probably you want to sprinkle the first few lines of the document with > a few "VersaClock 6" references? Something like this? --- a/Documentation/devicetree/bindings/clock/idt,versaclock5.txt +++ b/Documentation/devicetree/bindings/clock/idt,versaclock5.txt @@ -1,7 +1,7 @@ -Binding for IDT VersaClock5 programmable i2c clock generator. +Binding for IDT VersaClock 5,6 programmable i2c clock generators. -The IDT VersaClock5 are programmable i2c clock generators providing -from 3 to 12 output clocks. +The IDT VersaClock 5 and VersaClock 6 are programmable i2c clock +generators providing from 3 to 12 output clocks. ==I2C device node== >> @@ -7,18 +7,20 @@ from 3 to 12 output clocks. > > The rest looks OK to me, so > Acked-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> Thanks -- Best regards, Marek Vasut