Hi Geert > >> Does this affect H3 ES1.0, too? > >> My main worry there is that the name "ssi34_ctrl" is part of the DT ABI, > >> so we have to keep that as an alias for "ssi349_ctrl". > > > > I think this is from Gen3, not ESx. > > And no-one is using SSI34 on upstream code. > > Should we care about out-of-tree user ? > > Probably not, especially for H3 ES1.x. Sorry, I didn't explain. This is from Gen3, and ES1.x version datasheet has typo. But datasheet team no more update for it. For example on v0.5 datasheet (= for ES1.x) 6. Pin Function Controller (PFC) 6.2.2 GPIO/Peripheral Function Select Register (GPSR0-7) This has SSI_xxx_0129 (= this is typo), but 41. Serial Sound Interface Unit (SSIU) 41.1.3 External Pins This has SSI_xxx_01239 Can you agree about SSI_xxx_01239 / SSI_349 are from Gen3, not ES1.x ? > > OK. will do in v3 > > OK, thanks! Oops, sorry, not v3, but incremental patch. I will post this patch (= fixup SSI_349) if I could find my posted patches on your sh-pfc-for-v4.13. Best regards --- Kuninori Morimoto
