Re: [PATCH v2 02/10] pinctrl: sh-pfc: r8a7796: add Audio SSI pin support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert

> > +static const unsigned int ssi34_ctrl_pins[] = {
> > +       /* SCK, WS */
> > +       RCAR_GP_PIN(6, 5), RCAR_GP_PIN(6, 6),
> > +};
> > +static const unsigned int ssi34_ctrl_mux[] = {
> > +       SSI_SCK34_MARK, SSI_WS34_MARK,
> > +};
> 
> I'm a bit confused by this group: in the R-Car M3 Pin Function Rev. 0.54
> sheet, these are named SCK349 resp. WS349. According to the history, the
> change from {SCK,WS}34 to {SCK,WS}349 was made at the same time as the
> change from {SCK,WS}0129 to {SCK,WS}01239.
> However, the former change is not reflected in the PFC section of the
> Hardware User's Manual.
> 
> So which is correct: {SCK,WS}34 or {SCK,WS}349?
> 
> Can you please enlighten me?

It seems
SSI_SCK 0129 -> 01239 was happen on v0.51 timing,
SSI_SCK 34   -> 349   was happen on v0.54 timing.

r8a7795 is still using old (= 34) naming now.
I can adjust it both r8a7795/6.
Do you want to v3 patch for r8a7796 ?
or incremental patch is OK with r8a7795 ?

Best regards
---
Kuninori Morimoto



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux