Hi Morimoto-san, On Fri, May 12, 2017 at 2:13 AM, Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> wrote: > From: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> But before I queue it in sh-pfc-for-v4.13, I would like to have a clarification. > +static const unsigned int ssi34_ctrl_pins[] = { > + /* SCK, WS */ > + RCAR_GP_PIN(6, 5), RCAR_GP_PIN(6, 6), > +}; > +static const unsigned int ssi34_ctrl_mux[] = { > + SSI_SCK34_MARK, SSI_WS34_MARK, > +}; I'm a bit confused by this group: in the R-Car M3 Pin Function Rev. 0.54 sheet, these are named SCK349 resp. WS349. According to the history, the change from {SCK,WS}34 to {SCK,WS}349 was made at the same time as the change from {SCK,WS}0129 to {SCK,WS}01239. However, the former change is not reflected in the PFC section of the Hardware User's Manual. So which is correct: {SCK,WS}34 or {SCK,WS}349? Can you please enlighten me? Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds