Hi Niklas, On Fri, Apr 28, 2017 at 2:38 PM, Niklas Söderlund <niklas.soderlund@xxxxxxxxxxxx> wrote: > > On 2017-04-25 18:53:12 +0200, Geert Uytterhoeven wrote: >> Add all R-Car H2 Clock Pulse Generator Core Clock Outputs, as listed in >> Table 7.2a ("List of Clocks [R-Car H2]") of the R-Car Gen2 Hardware >> User's Manual rev. 2.00. >> >> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> >> --- /dev/null >> +++ b/include/dt-bindings/clock/r8a7790-cpg-mssr.h >> +#define R8A7790_CLK_R 33 >> +#define R8A7790_CLK_OSC 34 > > The last two are called RCLR and OSCCLK in the Table 7.2a ("List of > Clocks [R-Car H2]"). I'm sure this is intentional on your side, and if > so: It's a bit silly to have two clocks with "clk" in their name, while all others don't. We did the same on R-Car Gen3. > Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds