Hi Marek,
On Tue, Jan 24, 2017 at 5:39 PM, Marek Vasut <marek.vasut@xxxxxxxxx> wrote:
> On 01/24/2017 08:30 AM, Geert Uytterhoeven wrote:
>> On Tue, Jan 24, 2017 at 12:15 AM, Marek Vasut <marek.vasut@xxxxxxxxx> wrote:
>>> What about this ?
>>>
>>> - compatible: Should be "renesas,<chip>-gyroadc", "renesas,rcar-gyroadc".
>>> The <chip> can be either of:
>>> r8a7791 - for the GyroADC block present in r8a7791 SoC
>>> r8a7792 - for the GyroADC with interrupt block present
>>> in r8a7792 SoC
>>
>> No, we need the exact string in the document, cfr. all other Renesas bindings.
>>
>> "renesas,r8a7791-gyroadc"
>> "renesas,r8a7792-gyroadc"
>
> This ?
>
> - compatible: Should be "<soc-specific>", "renesas,rcar-gyroadc".
> The <soc-specific> should be one of:
> renesas,r8a7791-gyroadc - for the GyroADC block present
> in r8a7791 SoC
> renesas,r8a7792-gyroadc - for the GyroADC with interrupt
> block present in r8a7792 SoC
Yes. I had expected that double quotes were mandatory, but apparently
checkpatch doesn't require that.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
