On 01/24/2017 08:30 AM, Geert Uytterhoeven wrote:
> Hi Marek,
>
> On Tue, Jan 24, 2017 at 12:15 AM, Marek Vasut <marek.vasut@xxxxxxxxx> wrote:
>> On 01/23/2017 09:41 PM, Geert Uytterhoeven wrote:
>>> On Mon, Jan 23, 2017 at 8:56 PM, Marek Vasut <marek.vasut@xxxxxxxxx> wrote:
>>>> On 01/23/2017 06:08 PM, Rob Herring wrote:
>>>>> On Sat, Jan 21, 2017 at 03:42:11PM +0100, Marek Vasut wrote:
>>>>>> new file mode 100644
>>>>>> index 000000000000..081947367135
>>>>>> --- /dev/null
>>>>>> +++ b/Documentation/devicetree/bindings/iio/adc/renesas,gyroadc.txt
>>>
>>>>>> +Required properties:
>>>>>> +- compatible: Should be "renesas,<chip>-gyroadc", "renesas,rcar-gyroadc".
>>>>>
>>>>> Need to enumerate <chip>.
>>>>
>>>> It's enumerated below , the only special-case we handle at this point is
>>>> the r8a7792 , which has extra interrupt block which we don't use anyway,
>>>> but the driver disables those interrupts.
>>>
>>> It is not enumerated below. You just give an example for r8a7791.
>>>
>>> Please list all supported/tested compatible values, so checkpatch
>>> can validate compatible values in DTS patches adding GyroADC device
>>> nodes.
>>
>> What about this ?
>>
>> - compatible: Should be "renesas,<chip>-gyroadc", "renesas,rcar-gyroadc".
>> The <chip> can be either of:
>> r8a7791 - for the GyroADC block present in r8a7791 SoC
>> r8a7792 - for the GyroADC with interrupt block present
>> in r8a7792 SoC
>
> No, we need the exact string in the document, cfr. all other Renesas bindings.
>
> "renesas,r8a7791-gyroadc"
> "renesas,r8a7792-gyroadc"
This ?
- compatible: Should be "<soc-specific>", "renesas,rcar-gyroadc".
The <soc-specific> should be one of:
renesas,r8a7791-gyroadc - for the GyroADC block present
in r8a7791 SoC
renesas,r8a7792-gyroadc - for the GyroADC with interrupt
block present in r8a7792 SoC
--
Best regards,
Marek Vasut
