RE: [PATCH v2 1/3] mmc: sh_mobile_sdhi: add support for 2 clocks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Wolfram,

On Tuesday, January 17, 2017, Wolfram Sang wrote:
> Hi Chris,
> 
> > +	struct clk *clk2;
> 
> I'd vote for 'clk_cd' since we are explicitly requesting that clock for it.
> 
> > +	ret = clk_prepare_enable(priv->clk2);
> > +	if (ret < 0)
> > +		return ret;
> 
> You need to disable clk when failing.
> 
> Regards,
> 
>    Wolfram


Thanks for the feedback. I will make those changes.

Chris




[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux